TASK: improve robustness of FusionExceptionView #4050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
reviewed
Feb 21, 2023
| $dimensionSpacePoint, | ||
| VisibilityConstraints::frontend() | ||
| ); | ||
| } catch (\RuntimeException $e) { |
There was a problem hiding this comment.
I have seen these empty try/catch blocks make debugging real hard because they might hide an underlying exception (e.g. with persistence) – especially when used with low level SPL exceptions.
Shouldn't find*() return a nullable node?
| @@ -155,7 +168,11 @@ public function render() | |||
| return $output; | |||
| } | |||
|
|
|||
| return ''; | |||
| // There was an error during exception handling. Log the original exception instead. | |||
| $exception = $this->variables['exception']; | |||
There was a problem hiding this comment.
I didn't check but is this variable guaranteed to be set?
|
related: #3735 |
bwaidelich
changed the title
|
related #3190, maybe we can fix this here as well? |
6 tasks
|
Superseded by approach #4717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.