Experiment: Replace SiteEntity with SiteNodeAggregate
#4780
Conversation
| /** | ||
| * @var Site | ||
| * @ORM\ManyToOne(inversedBy="domains") | ||
| * @Flow\Validate(type="NotEmpty") | ||
| */ | ||
| protected $site; |
There was a problem hiding this comment.
how should the relation ship of
domain entity -> site node aggregate
work? Currently in this wip the domain wouldnt know its site directly but one has to fetch all site node aggregates and look into them
| public function findAll(): iterable | ||
| { | ||
| $cr = $this->contentRepositoryRegistry->get(ContentRepositoryId::fromString('default')); |
There was a problem hiding this comment.
how can we find all site node aggregates efficiently? Loop over all crs registered and fetch the node aggregates und the Neos.Neos:Sites node?
There was a problem hiding this comment.
that seems SUPER expensive for something that will happen on every request. (we could cache it of course).
If anything, I would see a custom projection for it?
mhsdesign
force-pushed
the
task/mergeSiteNodeAndSiteEntity
branch
from
a407cb0 to
b415aa0
Compare
mhsdesign
changed the title
SiteEntity with SiteNodeAggregate
mhsdesign
force-pushed
the
task/mergeSiteNodeAndSiteEntity
branch
from
806c0e2 to
5baa0b6
Compare
mhsdesign
force-pushed
the
task/mergeSiteNodeAndSiteEntity
branch
from
5baa0b6 to
ce4c272
Compare
|
Closing this experiment as written here
That could be worked around by caching or projections or other stuff but it might not be worth the hassle. At least definitely not for now. Also working with node aggregates is not easy at all, #4830 as we just want to use aggregate scoped properties but still have to issue the set properties command on a fake (random) dsp For the neos 9 release we will keep the site entity and domain entity as is. |
WIP
Related: #4470
only works for one site right now at time - no real domain support.
For migration use