BUGFIX: node:repair fails with could not be converted to string #4795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following crash during node:repair ```shell ./flow node:repair --dry-run --only removeBrokenEntityReferences Dry run, not committing any changes. Checking for broken entity references ... Object of class Neos\Flow\Persistence\Doctrine\Proxies\__CG__\Neos\Media\Domain\Model\ImageVariant could not be converted to string Type: Error File: Data/Temporary/Development/SubContextWbWeb/Cache/Code/Flow_Object_Classes/Neos_ContentRepository_Command_NodeCommandControllerPlugin.php Line: 836 ``` resolved neos#4794
christoph-daehne
force-pushed
the
4794-could-not-be-converted-to-string
branch
from
e72e954 to
1ea904d
Compare
kitsunet
reviewed
Dec 6, 2023
| $nodeData->getIdentifier(), | ||
| $propertyName, | ||
| $propertyType, | ||
| method_exists($propertyValue, '__toString') ? |
There was a problem hiding this comment.
I find the whole "referring to" questionable, because we just don't know what is in there, it could literally be any object, so if __toString is even a sensible representation of the object in question is doubtful, I would actually just remove this. But fine with the fix for now.
There was a problem hiding this comment.
I had similar thoughts, but preferred a small chance of helpful information over none ;)
kitsunet
approved these changes
Dec 6, 2023
ahaeslich
approved these changes
Dec 14, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following crash during node:repair
resolved #4794
Upgrade instructions
Tests have been created, run and adjusted as neededFEATURE|TASK|BUGFIX!!!and have upgrade-instructions