Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Content Repository status #4846

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

bwaidelich
Copy link
Member

!!! FEATURE: Content Repository status

  • Add `ProjectionInterface::status()``
  • Add ContentRepository::status() reflecting event store and projection statuses
  • Introduce DbalSchemaDiff utility for central and faster schema diffing (ContentRepository::setUp is too slow #4762)
  • Fix some projection schemas to prevent status from always returning SETUP_REQUIRED
  • Add CLI command cr:status

Resolves: #4468
Related: #4762

@bwaidelich
Copy link
Member Author

This is a draft because it depends on #4845

@dlubitz dlubitz self-requested a review January 21, 2024 13:00
@bwaidelich bwaidelich force-pushed the task/eventstore-1.0 branch 3 times, most recently from ae20335 to e9d2bdf Compare January 21, 2024 14:25
@bwaidelich bwaidelich force-pushed the feature/4468-contentrepository-status-2 branch from 8db105b to cd893ad Compare January 21, 2024 14:31
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the many repeatings of the status check code in each projection feels a bit "improvable", but I guess it make totally sence to keep this to each projection.

Base automatically changed from task/eventstore-1.0 to 9.0 January 22, 2024 13:30
@bwaidelich bwaidelich marked this pull request as ready for review January 22, 2024 13:31
@bwaidelich bwaidelich merged commit 06904c3 into 9.0 Jan 22, 2024
4 checks passed
@bwaidelich bwaidelich deleted the feature/4468-contentrepository-status-2 branch January 22, 2024 13:31
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Jan 23, 2024
Followup to neos#4846

- require a $details string for all non-ok status
- print "No details available." if verbose and non-ok and no details are available
- dont wortbreak details in verbose mode but print them with indentation of 2 full line per line
- print new line after printing details
- add details to AssetUsageProjection's setupRequired
neos-bot pushed a commit to neos/contentrepository-core that referenced this pull request Feb 2, 2024
Followup to neos/neos-development-collection#4846

- require a $details string for all non-ok status
- print "No details available." if verbose and non-ok and no details are available
- dont wortbreak details in verbose mode but print them with indentation of 2 full line per line
- print new line after printing details
- add details to AssetUsageProjection's setupRequired
neos-bot pushed a commit to neos/contentrepositoryregistry that referenced this pull request Feb 2, 2024
Followup to neos/neos-development-collection#4846

- require a $details string for all non-ok status
- print "No details available." if verbose and non-ok and no details are available
- dont wortbreak details in verbose mode but print them with indentation of 2 full line per line
- print new line after printing details
- add details to AssetUsageProjection's setupRequired
neos-bot pushed a commit to neos/neos that referenced this pull request Feb 2, 2024
Followup to neos/neos-development-collection#4846

- require a $details string for all non-ok status
- print "No details available." if verbose and non-ok and no details are available
- dont wortbreak details in verbose mode but print them with indentation of 2 full line per line
- print new line after printing details
- add details to AssetUsageProjection's setupRequired
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9.0 Feature projection status and cr:status command
2 participants