TASK: Followup 4330 remove plugin views #4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the UI adjusted neos/neos-ui#3689 we can get rid of the dummy endpoints.
I hope that deleting the correct translation key in english (content.inspector.editors.masterPluginEditor.selectPlugin) will lead to it being deleted everywhere?
mhsdesign
changed the title
grebaldi
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Hi @mhsdesign,
👍 by reading. I also ran the UI E2E tests with this PR patched-in for good measure. They ran - unsurprisingly - green :)
|
Thanks usually i do that too, but i trusted myself :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #4330
ui: neos/neos-ui#3689
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions