TASK: Unify JSON de/encoding behavior #5093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing CI is unrelated => #5094 |
mhsdesign
reviewed
Jun 12, 2024
| @@ -48,13 +48,13 @@ public static function fromAsset(Asset $asset): self | |||
| ); | |||
| } | |||
|
|
|||
| public static function fromJson(string $json): self | |||
| public static function fromJsonString(string $jsonString): self | |||
There was a problem hiding this comment.
ah nice i see you adjusted it to be in sync with the other parts thanks :)
I for one am perfectly fine with toJson() and fromJsonString() ... we discussed this briefly already in #4868 (comment)
There was a problem hiding this comment.
yep. I'm still not very fond of it – not only because it is asynchronous but because JSON is a string by definition. But consistency > correctness in this case I'd say
|
Mostly resolved with #5196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.