Merge: 8.3 to 9.0 and fix DBAL compatibility issues #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-establishes the Neos < 8.0 behavior of removed/nulled data structure keys With #3645 a lot of Fusion core logic was refactored. As an unwanted side-effect, `Neos.Fusion:DataStructure` prototypes (effectively all implementations of the `AbstractArrayFusionObject`) now behave differently when it comes to removed or nulled keys and ```fusion Neos.Fusion:DataStructure { someProperty > } ``` led to an array with: ```json {"someProperty":[]} ``` in Neos 8.0+. This fix reverts this side-effect, making the above return ```json [] ``` again. Fixes: #3859 Related: #3577, #3646
Re-establishes the Neos < 8.0 behavior of removed/nulled data structure keys ## Background: With #3645 a lot of Fusion core logic was refactored. As an unwanted side-effect, `Neos.Fusion:DataStructure` prototypes (effectively all implementations of the `AbstractArrayFusionObject`) now behave differently when it comes to removed or nulled keys and ```fusion Neos.Fusion:DataStructure { someProperty > } ``` led to an array with: ```json {"someProperty":[]} ``` in Neos 8.0+. This fix reverts this side-effect, making the above return ```json [] ``` again. Fixes: #3859 Related: #3577, #3646
Currently translated at 100.0% (143 of 143 strings) Translation: Neos/Neos.Media.Browser - Main - 8.3 Translate-URL: https://hosted.weblate.org/projects/neos/neos-media-browser-main-8-3/nl/
BUGFIX: Fix handling of unset/nulled DataStructure keys
BUGFIX: Workspace module: Tweak UX for collapsed rows in rewiew
The title text of impersonate button and restore button was always in english. Issue #4511
Currently translated at 100.0% (280 of 280 strings) Translation: Neos/Neos.Neos- Main - 8.3 Translate-URL: https://hosted.weblate.org/projects/neos/neos-neos-main-8-3/de/
Currently translated at 100.0% (143 of 143 strings) Translation: Neos/Neos.Media.Browser - Main - 8.3 Translate-URL: https://hosted.weblate.org/projects/neos/neos-media-browser-main-8-3/de/
Currently translated at 100.0% (323 of 323 strings) Translation: Neos/Neos.Neos - Modules - 8.3 Translate-URL: https://hosted.weblate.org/projects/neos/neos-neos-modules-8-3/de/
Currently translated at 95.3% (267 of 280 strings) Translation: Neos/Neos.Neos- Main - 8.3 Translate-URL: https://hosted.weblate.org/projects/neos/neos-neos-main-8-3/fr/
…-for-impersonate-button-in-user-management
In the default configuration this links to the content module, or to their user settings if they don’t have access to the content module. Resolves: #4799
…or-impersonate-button-in-user-management BUGFIX: Fix title attribute for impersonate button in user management
TASK: Upgrade to FontAwesome 6.5.2
Currently translated at 100.0% (143 of 143 strings) TASK: Translated using Weblate (German) Currently translated at 100.0% (324 of 324 strings) TASK: Translated using Weblate (German) Currently translated at 100.0% (4 of 4 strings) TASK: Translated using Weblate (German) Currently translated at 100.0% (4 of 4 strings) Co-authored-by: Alexander Girod <[email protected]> Translate-URL: https://hosted.weblate.org/projects/neos/neosmediabrowser-main-84/de/ Translate-URL: https://hosted.weblate.org/projects/neos/neosneos-modules-84/de/ Translate-URL: https://hosted.weblate.org/projects/neos/neosneos-nodetypespluginview-84/de/ Translate-URL: https://hosted.weblate.org/projects/neos/neosnodetypesassetlist-nodetypesassetlist-84/de/ Translation: Neos/Neos.Media.Browser - Main - 8.4 Translation: Neos/Neos.Neos - Modules - 8.4 Translation: Neos/Neos.Neos - NodeTypes/PluginView - 8.4 Translation: Neos/Neos.NodeTypes.AssetList - NodeTypes/AssetList - 8.4
FEATURE: Improve site:list command
This reverts commit 0c2509e.
TASK: Update textarea docs to latest version
…lity-8.4 FEATURE: Support doctrine/dbal 2.x and 3.x
|
This is just the upmerge with hopefully correctly fixed conflicts, will fail at the moment. |
|
I do not undestand why phpstan on CI shows different things than local |
Removes changes to autogenerated files and fixes missing Exception class usages in migrations.
|
I would merge this later if CI is green as upmerge & necessary followup. I tried to touch nothing that doesn't need to be touched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upmerge 8.4 > 9.0 and then fix everything necessary to make it work with DBAL 3.
Not deprecation cleanup, just necessary changes to make it work.
A follow up will change this to be DBAL 3 only and remove deprecations.