Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Fix mini cosmetic Todos #5178

Merged
merged 6 commits into from
Oct 23, 2024
Merged

TASK: Fix mini cosmetic Todos #5178

merged 6 commits into from
Oct 23, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Jul 8, 2024 •
edited
Loading

Following things have been adjusted (purely cosmetic)

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Jul 8, 2024
@mhsdesign
TASK: Followup neos#4353 adjust further usages of getIterator to us…
8362caf 
…e `yield from`

neos#4353
@mhsdesign
TASK: Remove obsolete class fields from behat context's
07f5eff
@mhsdesign
TASK: Clear up confusion in flow-query find documentation regarding '…
c2013df 
…global' scope

Its otherwise not obvious that the passed node doesnt need to be the side node if one wants to fetch a node beneath it
@mhsdesign
TASK: Make PropertyNames countable
eca9850 
Otherwise, one has to use `iterator_count` which is unnecessary complex
@mhsdesign
TASK: Remove redundant declaration in getIterator
f2e1bb2 
The type will already be declared via

```
@implements \IteratorAggregate<...>
```
@mhsdesign mhsdesign force-pushed the task/fix-mini-costmetic-todos branch from 417c744 to f2e1bb2 Compare October 17, 2024 18:51
@mhsdesign mhsdesign changed the title Task/fix mini costmetic todos TASK: Fix mini cosmetic Todos Oct 17, 2024
@mhsdesign mhsdesign marked this pull request as ready for review October 17, 2024 18:52
@github-actions github-actions bot added the Task label Oct 17, 2024
@mhsdesign
TASK: Fix Projections @implements \IteratorAggregate
ba2df8c 
> Method Neos\ContentRepository\Core\Projection\Projections::getIterator() return type with generic interface Neos\ContentRepository\Core\Projection\ProjectionInterface does not specify its types: TState
@mhsdesign mhsdesign requested review from mficzel and dlubitz October 17, 2024 18:57
@mhsdesign mhsdesign merged commit e84cbb7 into neos:9.0 Oct 23, 2024
9 checks passed
@mhsdesign mhsdesign deleted the task/fix-mini-costmetic-todos branch October 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

@mficzel mficzel Awaiting requested review from mficzel

@dlubitz dlubitz Awaiting requested review from dlubitz

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsdesign @bwaidelich