Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/5116: bundle js in Neos.Neos #5183

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Bugfix/5116: bundle js in Neos.Neos #5183

merged 1 commit into from
Aug 5, 2024

Conversation

so-grimm
Copy link
Contributor

Didn't know I needed to bundle the javascript manually, so that was missing in the original fix. This adds the necessary bundled files.

Issue: #5116

Upgrade instructions
No instructions necessary.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 8.3 label Jul 18, 2024
Sebobo
Sebobo approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnitto jonnitto merged commit 2ae7973 into neos:8.3 Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnitto jonnitto jonnitto approved these changes

@Sebobo Sebobo Sebobo approved these changes

@ahaeslich ahaeslich Awaiting requested review from ahaeslich

@markusguenther markusguenther Awaiting requested review from markusguenther

Assignees
No one assigned
Labels
8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@so-grimm @Sebobo @jonnitto