BUGFIX: Change workspace runs into endless while-loop

[pKallert]

Review instructions
Currently when switching the workspace in the UI it just runs endlessly and the docker container complains if you switch workspaces too often.

Apparently the bug was introduced here: PR

The line used to be
$nextBaseWorkspace = $contentRepository->getWorkspaceFinder()->findOneByName($nextBaseWorkspace->baseWorkspaceName);

and was changed to
$nextBaseWorkspace = $this->requireBaseWorkspace($workspace, $workspaceFinder);

since we always check for $workspace, the $nextBaseWorkspace always stays the same
Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[bwaidelich]

doh :)

[kitsunet]

Oof yeah, thanks for finding this!

[kitsunet]

I think this needs a rebase to after the DBAL changes?! That probably fixes the two CI problems.

[mhsdesign]

Before merging we should definitely come up with a test for this. The method is used in change base workspace which is apparently untested.

[kitsunet]

All dependencies fixed, tests green, as discussed today in our meeting, we merge this before the test as it's a nasty bug.