Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Changed from hardcoded date format to user-localized format. #5198

Merged
merged 1 commit into from
Aug 9, 2024
Merged

BUGFIX: Changed from hardcoded date format to user-localized format. #5198

merged 1 commit into from
Aug 9, 2024

Conversation

auwaerter
Copy link
Contributor

@auwaerter auwaerter commented Aug 9, 2024

Changes the hardcoded Y-m-d date format with an user-localized format.

German Interface Language
image

English Interface Language
image

Upgrade instructions

Tested within neos 8.3.15

Review instructions

Changed the branch to 8.3, as i've accidentally choose 8.0 👼
As discussed in slack we (actually Bastian) changed from a hardcoded date format to an user-localization.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Fix: Replaced hardcoded Y-m-d date format with user-localized format.
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@bwaidelich bwaidelich merged commit 2ea60ed into neos:8.3 Aug 9, 2024
13 checks passed
@kitsunet
Copy link
Member

kitsunet commented Aug 9, 2024

Ah sorry, I actually thought I pressed the merge button as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants