Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Ensure a valid target workspace name in node migrations #5212

Merged
merged 1 commit into from
Aug 17, 2024
Merged

BUGFIX: Ensure a valid target workspace name in node migrations #5212

merged 1 commit into from
Aug 17, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Aug 16, 2024 •
edited
Loading

Resolves #5199

Related to #5201

nezaniel
nezaniel approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as I don't care too much about the version / source workspace name switch

@kitsunet kitsunet merged commit 6dded19 into neos:9.0 Aug 17, 2024
11 checks passed
@mhsdesign mhsdesign changed the title BUGFIX: Ensure a valid target workspace name BUGFIX: Ensure a valid target workspace name in node migrations Aug 19, 2024
@dlubitz dlubitz deleted the bugfix/5199-target-workspace-name branch September 17, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nezaniel nezaniel nezaniel approved these changes

@kitsunet kitsunet kitsunet approved these changes

Assignees
No one assigned
Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Target workspaceName may exceed allowed workspaceName lenght on NodeMigration
3 participants
@dlubitz @kitsunet @nezaniel