TASK: Remove workspaceTitle, workspaceDescription and workspaceOwner use from behat core tests
#5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
feature/4726-extract-workspace-metadata-and-user-assignment-to-neos-wip
branch
from
d42c041 to
adce185
Compare
mhsdesign
reviewed
Oct 1, 2024
| @@ -73,7 +73,6 @@ Feature: Behavior of Node timestamp properties "created", "originalCreated", "la | |||
| | workspaceName | "user-test" | | |||
| | baseWorkspaceName | "review" | | |||
| | newContentStreamId | "cs-user" | | |||
| | workspaceOwner | "some-user" | | |||
There was a problem hiding this comment.
fyi workspaceOwner used ... but no effect
| @@ -44,7 +44,6 @@ Feature: Workspace rebasing - conflicting changes | |||
| | workspaceName | "user-test" | | |||
| | baseWorkspaceName | "live" | | |||
| | newContentStreamId | "user-cs-identifier" | | |||
| | workspaceOwner | "owner-identifier" | | |||
There was a problem hiding this comment.
fyi workspaceOwner used ... but no effect
| @@ -44,7 +44,6 @@ Feature: Workspace based content publishing | |||
| | workspaceName | "user-test" | | |||
| | baseWorkspaceName | "live" | | |||
| | newContentStreamId | "user-cs-identifier" | | |||
| | workspaceOwner | "owner-identifier" | | |||
| @@ -44,7 +44,6 @@ Feature: Workspace discarding - basic functionality | |||
| | workspaceName | "user-test" | | |||
| | baseWorkspaceName | "live" | | |||
| | newContentStreamId | "user-cs-identifier" | | |||
| | workspaceOwner | "owner-identifier" | | |||
mhsdesign
changed the title
workspaceTitle, workspaceDescription and workspaceOwner use from behat core tests
mhsdesign
approved these changes
Oct 1, 2024
Base automatically changed from
feature/4726-extract-workspace-metadata-and-user-assignment-to-neos
to
9.0
October 9, 2024 14:24
mhsdesign
deleted the
feature/4726-extract-workspace-metadata-and-user-assignment-to-neos-wip
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title, description and owner relation are now part of the Neos
WorkspaceMetadatamodel (see #5146)Related: #4726