BUGFIX: fix error during site import #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this lets the import run trough it will probably still be better to also have a proper flow fix in place. |
This adjusts the annotation to work with Flow 8.3.13 ... before the type with spaces was interpreted as `mixed` and caused the following error during site:import. ``` During the import of the "Sites.xml" from the package "Neos.Demo" an exception occurred: Error: During import an exception occurred: "Could not convert target type "Neos\Media\Domain\Model\ImageVariant": Could not convert target type "Neos\Media\Domain\Model\Adjustment\CropImageAdjustment", at property path "aspectRatio": Could not find a suitable type converter for "mixed" because the class / interface "mixed" does not exist."., see log for further information. ``` Resolves: neos#5448
mficzel
force-pushed
the
bugfix/fixErrorDuringSiteImport
branch
from
04628c6 to
e35d4de
Compare
dlubitz
approved these changes
Jan 22, 2025
|
We should discuss wether reverting the flow change is the better option. Adjusting type hints in a minor is not the best solution I can think of. |
|
Yes we can discuss this. But from my POV the change just fixes (accidentially) a bug that allowed to have wrong |
|
For PHP both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the annotation to work with Flow 8.3.13 ... before the type with spaces was interpreted as
mixedand caused the following error during site:import.Resolves: #5448
Review instructions
The new behavior was introduced to flow with pr: neos/flow-development-collection#3424
Checklist
FEATURE|TASK|BUGFIXReviewer - Breaking Changes are marked with!!!and have upgrade-instructions