-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Benchmark basics #105
Conversation
Introduces a phpbench.json with configuration for phpbench and a composer script to execute the benchmarks. PhpBench is to be installed via phive phive install phpbench
We could also put the phpbench.json into the BuildEssentials.... Matter of choice really. I wouldn't mind either way. Any opionions. |
Unfortunately using the |
What is Why that? Why not via composer? |
I do not want the dependency in the project, it makes no sense for tools like this IMHO. All build tools should rather come as phar to be independent of the codebase. Although phive has it#s problems (mainly missing maintenance atm). But I would still suggest ot anyone to install this as phar. But sure we can still decide to add it as require-dev in the future |
In theory yes, in practice that caused problems in the past, whenever you had differences in PHP versions e.g. that broke things. Seeing that I was just a bit surprised, had never heard of the tool and wonder if we need to add some pointers or hints to some documentation? |
@kitsunet and I discussed this briefly and wondered where a good place would be for this. |
We could add it |
Introduces a phpbench.json with configuration for phpbench and a composer script to execute the benchmarks.
PhpBench is to be installed via
phive install phpbench
Relates: neos/flow-development-collection#3361
Relates: neos/BuildEssentials#71