Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions dependencies to latest version #191

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Dec 11, 2024

Update github actions:

  • actions/checkout@v3 -> actions/checkout@v4
  • actions/cache@v2 -> actions/cache@v4

Also fixing, the pipeline. Now it runs also on branches. Needed some quirk to fulfill the dependency requirements of the neos/neos-base-distribution or moreover of the required neos/demo package as this already require the neos/seo package in a given version (~4.1).

@dlubitz dlubitz changed the title Update actions dependencies to latest version Update github actions dependencies to latest version Dec 11, 2024
@kdambekalns kdambekalns merged commit 8027c59 into 4.x Dec 11, 2024
2 checks passed
@kdambekalns kdambekalns deleted the dlubitz-patch-1 branch December 11, 2024 21:32
@kdambekalns
Copy link
Member

Dang, after the merge it fails…

Run git clone --depth 1 --branch 9.0 https://github.com/neos/neos-development-distribution.git ${FLOW_PATH_ROOT}
  git clone --depth 1 --branch 9.0 https://github.com/neos/neos-development-distribution.git ${FLOW_PATH_ROOT}
  cd ${FLOW_PATH_ROOT}
  composer config --no-plugins allow-plugins.neos/composer-plugin true
  
  git -C ../neos-seo checkout -b ${PACKAGE_TARGET_VERSION}
  composer config repositories.package '{ "type": "path", "url": "../neos-seo", "options": { "symlink": false } }'
  composer require --no-update --no-interaction neos/seo:@dev
  composer require --dev --no-update --no-interaction phpstan/phpstan:^1.10
  shell: /usr/bin/bash -e {0}
  env:
    FLOW_PATH_ROOT: ../neos-base-distribution
    PACKAGE_FOLDER: neos-seo
    PACKAGE_TARGET_VERSION: 4.x
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1
Cloning into '../neos-base-distribution'...
fatal: a branch named '4.x' already exists
Error: Process completed with exit code 128.

@dlubitz
Copy link
Contributor Author

dlubitz commented Dec 11, 2024

Ihhhh.... I'll take care of this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants