WIP: Isolate Drawer menu from the rest of the UI #3773
Conversation
grebaldi
force-pushed
the
feature/multi-app/02-loosen-the-menu
branch
2 times, most recently
from
5666f1d to
acbdd0a
Compare
grebaldi
force-pushed
the
feature/multi-app/02-loosen-the-menu
branch
from
4c78c28 to
ebaf71e
Compare
Prelude to: #3773 refs: #3119 This PR reforms the UI's i18n mechanism by exposing a new function `translate` directly from the `@neos-project/neos-ui-i18n` package. The function looks as follows: ```typescript function translate( fullyQualifiedTranslationAddressAsString: string, fallback: string | [string, string], parameters: Parameters = [], quantity: number = 0 ): string; ``` And can be used like this: ```typescript translate( 'Neos.Neos:Main:workspaces.allChangesInWorkspaceHaveBeenDiscarded', 'All changes from workspace "{0}" have been discarded.', ['user-admin'] ); // output (en): All changes from workspace "user-admin" have been discarded. ``` The new mechanism is completely independent from registries. There's no longer a need for injecting the `I18nRegistry` to use translations, instead `translate` can be used directly. `translate` will only work after the translations have been loaded during the bootstrapping process of `@neos-project/neos-ui`. If it is used too early, it throws an exception. The function now also properly supports plural rules (via [`Intl` Web API](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl)). Tha `I18nRegistry` had only supported English plurals, but with broken rules (quantity=0 yielded singular instead of plural). Other changes included in this PR are: - Everything in `@neos-project/neos-ui-i18n` is now TypeScript (save `manifest.js`) - The `<I18n/>`-component was deprecated - The `I18nRegistry` is now properly documented, but was also deprecated - The `xliff.json` endpoint is now discovered via `<link>`-tag, instead of initial data - The `<link>`-tag is marked with `prefetch` to slightly speed up the fetch request - The `@neos-project/neos-ui-i18n` now has a comprehensive README.md This change is breaking, because translations may have relied on the broken plural rules. It is also breaking, because the signature for substitution parameters has changed slightly - although this should be non-breaking at runtime.
|
Edit because the commits were split cleanly i was able to reset hard to 9.0 and just cherry pick all the changes you did after the original translation changes were made. That effectively drops the double commits. To confirm that the changes are correct i did a diff to my merge approach and even found an error in my merge resolution: (i had kept the Aside from that i checked it out and fixed the linter and it compiles and from the looks of it works already. As this is wip there obviously still some todos in the code. Thanks again for your work as always! |
Until now, dropdown contents were `null`ed when the dropdown is closed. This leads to unneccessary re-renders every time the dropdown visibility is toggled. This commit changes this logic. Dropdown contents are now always rendered, but hidden when the dropdown is closed.
mhsdesign
force-pushed
the
feature/multi-app/02-loosen-the-menu
branch
from
9121cf6 to
d1f2456
Compare
refs: #3119
previous: #3682
depends on: #3792, #3804
WIP.