TASK: Upgrade to FontAwesome 6.5.2

[wiegandj]

Issue: #3793

Upgraded FontAwesome in neos-ui to 6.5.2.

Versions were tested in neos-development-collection before.

See upgrade for neos-development-collection:
Issue: neos/neos-development-collection#5107
PR: neos/neos-development-collection#5108

[ahaeslich]

@wiegandj can you please rebase this change onto the 8.4 branch. This way no unrelated commits will show up in your PR.

[Sebobo]

I had to ignore some type related issues with our FA Icons component. We can either merge it like this and fix this separately or find a fix.
The TS error message was too convoluted for me to understand right now.

Ping @grebaldi @markusguenther @mhsdesign maybe one of you can understand the error.

[grebaldi]

@Sebobo

I had to ignore some type related issues with our FA Icons component. We can either merge it like this and fix this separately or find a fix.
The TS error message was too convoluted for me to understand right now.

Our IconProps extend the FontAwesomeIconProps imported from @fortawesome/react-fontawesome. Since FortAwesome/react-fontawesome@e32a0cb (so, v0.2.0 of @fortawesome/react-fontawesome) FontAwesomeIconProps extends RefAttributes<SVGSVGElement>, which implies the following definition for a ref prop:

{
  ref?: Ref<SVGSVGElement>
}

This definition collides with the intrinsic ref prop that is defined for every class component, in the case of our FontAwesomeIcon component that would be:

{
  ref?: LegacyRef<FontAwesomeIcon>
}

This can be easily fixed by adjusting the type definition for our IconProps (in

neos-ui/packages/react-ui-components/src/Icon/icon.tsx

Line 27 in 1875868

export interface IconProps extends Omit<FontAwesomeIconProps, 'icon'> {

) thusly:

-export interface IconProps extends Omit<FontAwesomeIconProps, 'icon'> {
+export interface IconProps extends Omit<FontAwesomeIconProps, 'icon' | 'ref'> {

If it's easier, I think it'd be okay to do this post-merge. But this branch needs a rebase anyway.

[Sebobo]

I rebased, solved conflicts and fixed the type issue like you described @grebaldi, thx a lot!
I also found that icons in dropdowns were suddenly to large as the font awesome class fa-w-16 does not exist anymore (so much for not breaking). So I had to fix that in the places I found.

[grebaldi]

Thanks for taking care of the update, @wiegandj! And thanks for rebasing and solving conflicts @Sebobo!

I updated the failing snapshot test and fixed the icon reference in that one E2E test case. Everything should be green when CI is done.