FEATURE: Mark inherited disabled nodes in document and content tree #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Jan 13, 2025
Comment on lines
105
to
108
| '_hidden' => $node->tags->withoutInherited()->contain(SubtreeTag::disabled()), | ||
| '_hiddenByAncestors' => $node->tags->onlyInherited()->contain(SubtreeTag::disabled()), | ||
| '_hiddenInIndex' => $node->getProperty('hiddenInMenu'), | ||
| '_hasTimeableNodeVisibility' => |
There was a problem hiding this comment.
all this stuff is slightly getting more and more bloated ... i dont like that :D maybe we should do something similar to what we have done with other data: use bit masks ... this is especially useful to denote that there is likely of all the things only one state that we really want to highlight in the ui.
neos-ui/packages/neos-ui-redux-store/src/CR/Workspaces/index.ts
Lines 12 to 17 in 81d01be
aside from this the chnage looks good :D Code wise it looks fine and should work ... is there anything missing than to disucss if we like to keep introducing data bloat :D ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3896
This marks nodes, which are disabled by inheritence, because a ancestor node is disabled, with a dedicated icon.