Feature/db structure #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/accounting into feature/service-refactor
…/accounting into feature/service-refactor
…/accounting into feature/service-refactor
…/accounting into feature/service-refactor
LICENSE.txt
Outdated
| @@ -1,6 +1,6 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) <Scott Laurent> | |||
| Copyright (c) <Neptune Software> | |||
There was a problem hiding this comment.
Copyright (c) 2020 Neptune Software
CHANGELOG.md
Outdated
Comment on lines
10
to
15
| ## 2020-03-18 | ||
| ### Added | ||
| - Author names | ||
| ### Changed | ||
| - Namespaces refactored | ||
| - ModelTraits folder's name to Traits |
CHANGELOG.md
Outdated
| ### Added | ||
| - Interfaces | ||
| - Service layer | ||
| - php.yml |
There was a problem hiding this comment.
GitHub Actions for build status and auto unit testing.
composer.json
Outdated
Comment on lines
8
to
9
| "name": "Neptune Software", | ||
| "email": "info@neptunyazilim.com" |
| @@ -7,9 +7,7 @@ | |||
| convertNoticesToExceptions="true" | |||
| convertWarningsToExceptions="true" | |||
| processIsolation="false" | |||
| stopOnFailure="false" | |||
| syntaxCheck="false" | |||
| /** | ||
| * @var string | ||
| */ | ||
| protected $table = 'accounting_journals'; |
There was a problem hiding this comment.
table names could be configurable in another branch
| /** | ||
| * @throws DebitsAndCreditsDoNotEqual | ||
| */ | ||
| private function verifyTransactionCreditsEqualDebits() |
There was a problem hiding this comment.
this method is not defined in the interface
| @@ -76,7 +76,7 @@ public function testJournalObjectReferences() | |||
|
|
|||
| $account = $this->createFakeAccount(); | |||
| $account->initJournal(); | |||
| $account_journal = Account::find(1)->journal; | |||
| $account_journal = Account::all()->first()->journal; | |||
There was a problem hiding this comment.
just a note (no change required):
Account::inRandomOrder()->first
tests/Models/CompanyJournal.php
Outdated
Comment on lines
27
to
34
| static::creating(function ($model) { | ||
| /** | ||
| * @var \Illuminate\Database\Eloquent\Model $model | ||
| */ | ||
| if (!$model->getKey()) { | ||
| $model->{$model->getKeyName()} = Str::uuid()->toString(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
this could be a tiny trait for all models. this code block repeats itself more than +3 times.
| @@ -13,7 +13,7 @@ class CreateAccountingLedgersTable extends Migration | |||
| public function up() | |||
| { | |||
| Schema::create('accounting_ledgers', function (Blueprint $table) { | |||
| $table->increments('id'); | |||
| $table->uuid('id')->primary(); | |||
| $table->string('name'); | |||
| $table->enum('type', ['asset', 'liability', 'equity', 'income', 'expense']); | |||
There was a problem hiding this comment.
enum is hard to maintain. keep the type control in the code. for example: policies or validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed ids from integer to uuid