Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch issue comments #115

Merged
merged 8 commits into from
Sep 10, 2020
Merged

Fetch issue comments #115

merged 8 commits into from
Sep 10, 2020

Conversation

mvolpato
Copy link
Contributor

@mvolpato mvolpato commented Sep 5, 2020

  • Adds GET /repos/:owner/:repo/issues/comments for Issues API Calls #38 .
  • Adds Reactions to Comment. To get Reactions we need to add a custom header:
  • Adds custom headers for GitHub API previews.
  • Adds application/vnd.github.squirrel-girl-preview custom header (Reactions).
  • Tests updated and/or added.

Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Added some opinions, open for discussion 😊

OctoKit/Issue.swift Outdated Show resolved Hide resolved
OctoKit/Issue.swift Outdated Show resolved Hide resolved
OctoKit/PreviewHeader.swift Outdated Show resolved Hide resolved
OctoKit/PreviewHeader.swift Show resolved Hide resolved
OctoKit/Reactions.swift Outdated Show resolved Hide resolved
@pietbrauer
Copy link
Member

This one has merge conflicts now 😬 Could you resolve them?

@pietbrauer pietbrauer merged commit 0d26475 into nerdishbynature:master Sep 10, 2020
@pietbrauer
Copy link
Member

Thanks again!

tngranados pushed a commit to tngranados/octokit.swift that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants