-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async notifications support + added endpoints #183
Async notifications support + added endpoints #183
Conversation
Before merging, I've found an issue. For the pagination params around notifications, if I keep them as But then the API returns correct data despite this. so I'm not sure what exactly is going on here. |
@LucasCoderT Have you looked at the resulting URLs? Are they the same? URL Params don't have types so I doubt |
Apologies, I think this had something to do with my local environment. When I tried it on my laptop instead of my desktop it responds and follows the params as expected. Weird. This PR should be good to go then 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🌷
NotificationThread
andSubject
markThreadasDone
endpoint support