Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some more fields to repo, and structure for organization #191

Merged

Conversation

armcknight
Copy link
Contributor

Hi @nerdishbynature, thanks for offering this package. I had a need for a few extra things from it, so wanted to offer this PR. Thanks!

@pietbrauer
Copy link
Member

Thanks for the PR. Some tests would be nice!

@armcknight
Copy link
Contributor Author

Added tests! While resolving the conflict I realized I had duplicated the functionality in Stars.swift in new functionality in Repositories.swift, so I removed mine.

@armcknight
Copy link
Contributor Author

Is there a reason NotificationTests.swift isn't part of the Xcode project and only runs in the SPM tests?

@pietbrauer
Copy link
Member

Is there a reason NotificationTests.swift isn't part of the Xcode project and only runs in the SPM tests?

No particular reason. I guess someone just forgot to add it as it's very easy to forget nowadays with Xcode opening the project as a package first. We can get rid of the Xcode Project at some point if we only want to support SPM and discard Carthage.

Search Tests seem to fail for some reason once it's ready we can merge it.

@armcknight
Copy link
Contributor Author

armcknight commented Sep 27, 2024

Fixed the remaining issues @pietbrauer! One question, have you ever considered using pre-commit so the lint issues don't present an extra CI run? (see SwiftFormat's docs on it: https://github.com/nicklockwood/SwiftFormat?tab=readme-ov-file#git-pre-commit-hook)

Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I am personally not a huge fan of pre-commit hooks as it requires people to have the tool installed to make a commit.

@pietbrauer pietbrauer merged commit 1e63f58 into nerdishbynature:main Sep 28, 2024
9 checks passed
@armcknight armcknight deleted the add-org-and-other-repo-properties branch October 1, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants