Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend User api #199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend User api #199

wants to merge 2 commits into from

Conversation

marosoaie
Copy link

  • allow fetching users by id
  • rename existing API to make it clear which case is used for fetching by name vs fetching by id

Extend User api
6403d4f 
- allow fetching user by its unique id
pietbrauer
pietbrauer requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it needs some tests for the newly added API.

@marosoaie marosoaie requested a review from pietbrauer January 6, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietbrauer pietbrauer Awaiting requested review from pietbrauer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marosoaie @pietbrauer