Clean stale DeviceConnections

[joshk]

I noticed in the DB that we have several old/stale device connections.

Upon looking into this more, I realised that when we added the DeviceConnection schema and relationships, we didn't add a way to clean the stale connections, which might linger due to unforeseen circumstances, like the app crashing.

[lawik]

Looks like a win ✨

[nshoes]

LGTM!

1.) Since we're here, should we add a function that deletes old device_connections and call it from CleanDeviceConnectionStates?

2.) Could we get a test or two for CleanDeviceConnectionStates?

[joshk]

Sooooo, I'm going to cheat a little.

1.) Since we're here, should we add a function that deletes old device_connections and call it from CleanDeviceConnectionStates?

#1750

2.) Could we get a test or two for CleanDeviceConnectionStates?

#1751

I agree on both your points but I'm going to do those in different PRs so I can at least get the current issue of stale device connection rows fixed. I've created issues for these so they aren't forgotten.