Add owner role support #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update checks for admin to include owner role Updated role list to include role for users Updated activity with new event type handler
Comment on lines
+365
to
+378
| case "transferred.owner.role": | ||
| if (event.meta.email || event.meta.username || event.target_id) { | ||
| return renderMultiRowSpan( | ||
| event.meta.username ? event.meta.username : event.target_id, | ||
| event.meta.email ? event.meta.email : "User" | ||
| ); | ||
| } | ||
| if (event.meta.user_name) { | ||
| return renderMultiRowSpan( | ||
| event.meta.user_name, | ||
| event.meta.is_service_user ? "Service User" : "User" | ||
| ); | ||
| } | ||
| return "-"; |
There was a problem hiding this comment.
Why are we duplicating this code?
There was a problem hiding this comment.
Now when I checked closer I saw for PATs we also duplicate the same code
pascal-fischer
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update checks for admin to include owner role
Updated role list to include role for users
Updated activity with new event type handler
Links to: netbirdio/netbird#1340