-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[management] Feature - Migration to Zitadel v2 API #2994
base: main
Are you sure you want to change the base?
Conversation
Thank you for the contribution @remipcomaite |
Hello @braginini , The code is not backwards compatible because V1 of the API will be deprecated in the long term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
management/server/idp/zitadel.go:73
- The variable name 'ID' has been changed to 'userId'. Ensure that this renaming is consistently applied throughout the codebase to avoid confusion.
ID: string `json:"userId"`
@remipcomaite when was v1 support removed from Zitadel? |
@mlsmaycon I don't know but v1 (service-based) and v2 (resource-based) are GA. |
Quality Gate passedIssues Measures |
Thanks for checking @remipcomaite. I've asked in Zitadel's community discord, and it appears that they don't have a plan to deprecate the API yet. But the notification gives us an idea of the overall intentions. With that said, the problem with dropping V1 support on our end is that self-hosted users would have to upgrade their Zitadel's servers before updating NetBird's management service, and that will generate Github and Slack requests for assistance, which we can't provide. An alternative to that is to make v2 support optional on our side and keep v1 support for those users. That could be an IDP extra configuration, which, by default, uses V1, but we set our deployment scripts and guides to use V2. What do you think? |
Yes, I think it's the best option. |
Describe your changes
Hello,
I propose a PR to migrate to Zitadel API v2.
This allows to authenticate users from different organizations.
The endpoint for the management API changes from "/management/v1" to "/v2".
Issue ticket number and link
Checklist