Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor typos in README.md #938

Closed
wants to merge 2 commits into from

Conversation

vivekvashist
Copy link
Contributor

@vivekvashist vivekvashist commented Apr 24, 2024

Set develop as target branch of this PR (delete this line before issuing the PR)

Test inclusion requirements

In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:

  • any fix or enhancement SHOULD include relevant new tests or test updates, if any tests need updating.
  • a new platform support MUST include the relevant input files similar to what we have in tests/integration/sqcmds/-input directories, along with the relevant tests in the tests/integration/sqcmds/-samples dir. That list MUST include the all.yml file fully filled out.
  • any new service (or table) addition MUST include comments about what network OS are supported (along with version) with this command along with test samples for those platforms and input files in the *-input dir

For additional information about tests, follow this link

Related Issue

Fixes #

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

New Behavior

...

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Comments

Include additional comments about the this pull request

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR source branch is created from the develop branch.
  • My PR targets the develop branch.
  • All my commits have --signoff applied

@ddutt
Copy link
Member

ddutt commented Apr 26, 2024

Thanks for the contribution, @vivekvashist

@ddutt
Copy link
Member

ddutt commented May 21, 2024

@vivekvashist please add a sign-off to your commit, or we cannot accept it.

Copy link
Member

@ddutt ddutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a sign-off to your commit

@mjbear
Copy link
Contributor

mjbear commented Aug 10, 2024

@vivekvashist please add a sign-off to your commit, or we cannot accept it.

@vivekvashist
💡 For your existing commits, you'll want to run git commit --amend --signoff
(I don't think Dinesh will need you to sign your merge commit, but if you wanted to do that add in HEAD~2 to the above command. Probably best to just do so to be safe.)

🥇 While performing commits the sign off text can be added like so git commit --signoff (enter your commit message and save). If you use a GUI for the commits there might be settings to enable --signoff.

I hope this helps.
(Beware the longer this PR goes unmerged the more chances of a merge conflict that will need resolved.)

@vivekvashist
Copy link
Contributor Author

I'll resubmit this shortly.

@vivekvashist vivekvashist deleted the patch-1 branch August 11, 2024 04:27
@vivekvashist vivekvashist mentioned this pull request Aug 11, 2024
5 tasks
@mjbear
Copy link
Contributor

mjbear commented Aug 11, 2024

I'll resubmit this shortly.

Why close this one and resubmit?

You were almost done. 😀 There was one step needed (--signoff) and the rest was viable since Dinesh did not point out any other issues.

💡 You can always re-open this PR, fix up the commit signing, and have it ready for the SuzieQ team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants