-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix minor typos in README.md #938
Conversation
Thanks for the contribution, @vivekvashist |
@vivekvashist please add a sign-off to your commit, or we cannot accept it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a sign-off to your commit
@vivekvashist 🥇 While performing commits the sign off text can be added like so I hope this helps. |
I'll resubmit this shortly. |
Why close this one and resubmit? You were almost done. 😀 There was one step needed ( 💡 You can always re-open this PR, fix up the commit signing, and have it ready for the SuzieQ team. |
Set
develop
as target branch of this PR (delete this line before issuing the PR)Test inclusion requirements
In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:
For additional information about tests, follow this link
Related Issue
Fixes #
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
New Behavior
...
Contrast to Current Behavior
...
Discussion: Benefits and Drawbacks
...
Changes to the Documentation
...
Proposed Release Note Entry
...
Comments
Include additional comments about the this pull request
Double Check
develop
branch.develop
branch.--signoff
applied