Eos routes wrong nexthopIps for protocol=connected entries #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases we receive 0.0.0.0 as nexthopIps for an entry where the protocol is connected. In those cases the nexthopIps list must be empty Signed-off-by: AndryNick98 <[email protected]>
LucaNicosia
reviewed
May 21, 2024
| @@ -48,6 +48,8 @@ def _clean_eos_data(self, processed_data, _): | |||
| entry['oifs'] = len(entry['nexthopIps']) * \ | |||
| ['_nexthopVrf:default'] | |||
| entry['protocol'] = entry['protocol'].lower() | |||
| if entry['protocol'] == 'connected': | |||
There was a problem hiding this comment.
In the commit you are saying that you should do this change only when 0.0.0.0 as nexthopIps. Here you are always updating it (hence you are not checking if nexthopIps == '0.0.0.0'. Is it the right thing to do?
There was a problem hiding this comment.
the point is that the nexthopIps list should be always empty if the protocol is connected. That was just an explanation of the bug, there are some cases where we put 0.0.0.0 as nexthopIps even if the protocol is connected, so here we just set nexthopIps as empty every time we have protocol=connected , it doesn't metter checking if nexthopIps is equal to 0.0.0.0 or not.
ddutt
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With eos devices, when we have an entry with protocol = connected we put 0.0.0.0 as nexthopIps while we should leave it empty.
The PR fix it
Type of change
Double Check
developbranch.developbranch.--signoffapplied