Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lldp cisco #946

Merged
merged 2 commits into from
May 23, 2024
Merged

Fix lldp cisco #946

merged 2 commits into from
May 23, 2024

Conversation

AndryNick98
Copy link
Collaborator

Description

This PR fix these issue related to lldp cisco management:

  • Inconsistent behavior when both lldp and cdp are enabled on a device
  • Not getting description, and mgmt IP from LLDP/CDP on NXOS

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR source branch is created from the develop branch.
  • My PR targets the develop branch.
  • All my commits have --signoff applied

@ddutt ddutt merged commit 3a96659 into develop May 23, 2024
13 checks passed
@ddutt ddutt deleted the fix-lldp-cisco branch May 23, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddutt ddutt ddutt approved these changes

@claudious96 claudious96 claudious96 approved these changes

@Sepehr-A Sepehr-A Awaiting requested review from Sepehr-A

@LucaNicosia LucaNicosia Awaiting requested review from LucaNicosia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndryNick98 @ddutt @claudious96