Fix sonic routes version 4.2 #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it separate sonic in a list to be able to differentiate between versions higher than 4.2 and lower than that. It add for sonic 4.2 the command to retrive the vrfs name associated with ids Signed-off-by: AndryNick98 <[email protected]>
- created sonic_routes_v42.tfsm: template specific for route command in sonic v42 where entries contains the vrf id instead of the vrf name - created sonic_vrf_show.tfsm: template to parse the output of the ip vrf show command, useful to get the vrf name Signed-off-by: AndryNick98 <[email protected]>
we swap the order of operators in the operators dict because otherwise operators like ge(>=) and le(<=) don't work correctly. without this change for example gt(>) would be selected instead of ge(>=) Signed-off-by: AndryNick98 <[email protected]>
Added the code to manage correctly those routing table entries that have the vrf id instead of the vrf name Signed-off-by: AndryNick98 <[email protected]>
ddutt
approved these changes
May 21, 2024
claudious96
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SONIC 4.2 doesn't provide the VRF name in the route table output. We need to extract the vrf from the output of ip vrf.
This PR implement the fix
Type of change
Double Check
developbranch.developbranch.--signoffapplied