Fix route action protocol #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndryNick98
force-pushed
the
fix-route-action-protocol
branch
from
c9c19e3 to
6f48982
Compare
The existing poller for routes doesn't normalize protocol correctly across vendors. so, this patch makes connected routes be "connected", and not "direct" (Cisco and Junos). Signed-off-by: Dinesh Dutt <[email protected]>
The poller didn't normalize protocol and action correctly. This patch corrects them for existing data. Signed-off-by: Dinesh Dutt <[email protected]>
Signed-off-by: AndryNick98 <[email protected]>
AndryNick98
force-pushed
the
fix-route-action-protocol
branch
from
6f48982 to
9db881d
Compare
ddutt
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normalizing action and protocol in routes.
protocol=direct, it needs to be parsed asconnectedaction=local, it needs to ba parsed asforwardType of change
Double Check
developbranch.developbranch.--signoffapplied