ipv6 neighbor data gathering for junos #971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @amylieb Could you please squash the last two commits as one (the code and the typo fix)? Also, you'll need to move the PR out of draft state for me to merge it. |
Signed-off-by: Amy Liebowitz <[email protected]>
amylieb
force-pushed
the
ipv6-neighbors-for-junos
branch
from
3afa9ab to
b22197d
Compare
|
Thanks @ddut - done. I'm new to contributing to open source projects, but I hope to contribute more to this one in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test inclusion requirements
I browsed through the test folder but didn't see an obvious place to augment an existing test, though I could definitely be missing something. Let me know if there's a particular file I can add data to, or if there's an example of an existing test I could emulate.
Related Issue
N/A
Description
Gather IPv6 neighbor data from junos devices.
Type of change
New Behavior
Added a command to arpnd.yaml for gathering ipv6 neighbor data
Contrast to Current Behavior
Currently only IPv4 arp data is gathered for arpnd for junos.
Discussion: Benefits and Drawbacks
Why do you think this project and the community will benefit from your
proposed change? More complete data gathered for junos.
What are the drawbacks of this change? None (at least I can think of)
Is it backwards-compatible? Yes
Anything else that you think is relevant to the discussion of this PR.
Not sure why this data isn't already being gathered, it's not really indicated in the documentation that only arp data is gathered for Junos, and it's an easy thing to implement. My organization has a large Junos deployment and gathering IPv6 neighbor data from these devices is a requirement if we plan to leverage suzieq.
Changes to the Documentation
N/A
...
Proposed Release Note Entry
IPv6 neighbor data gathering for junos
Comments
N/A
Double Check
developbranch.developbranch.--signoffapplied