This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Fix calculation to apply taxes after discount #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraerino
changed the title
mraerino
force-pushed
the
fix/calculation-discounts-taxes
branch
from
eda3bb7 to
7319eb9
Compare
Introduces the field "NetTotal" for orders and price items. This field represents the net amount of a single item or an order that taxes are calculated based on. While the "subtotal" amount is not discounted, the "NetTotal" is. This is especially important when prices are expected to include taxes. In these cases discounts are applied to the original price and then the net price is calculated. The test values are synced with those in GoCommerce.
mraerino
force-pushed
the
fix/calculation-discounts-taxes
branch
from
7319eb9 to
2271c04
Compare
mraerino
changed the title
|
@bcomnes this has been updated to do the same as what has been refined in my GoCommerce PR. Description about tests etc still applies. |
|
Triaged this today. Will review soon. |
|
@bcomnes the only thing that is changed and not added in this fix is the behavior of the tax amount field. but since the behavior was wrong before (considering any taxation system in US or Europe) it should rather be classified as a bug fix than a breaking change. |
|
OK sounds good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
This PR replicates netlify/gocommerce#155 for the JS lib.
The tests have been synced manually to verify similar behavior.