Fix rounding inaccuracies with quantity #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraerino
force-pushed
the
fix/calculation-rounding-amounts
branch
from
d595c35 to
27b548f
Compare
mraerino
changed the title
|
@bcomnes This is rebased on the master now and ready to go. If you want to do api changes for expressing line item amounts properly before, we can postpone this. It is not based on an existing issue but I noticed this flaw when digging into the calculation logic. |
There was a problem when using a quantity higher than 1 because quantities were applied after rounding, therefore multiplying rounding inaccuracies which is not acceptable. Currently the amounts output in line items does not reflect the more accurate values. There needs to be an API change to display single and total amounts for items in orders.
mraerino
force-pushed
the
fix/calculation-rounding-amounts
branch
from
27b548f to
61a8e7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
There was a problem when using a quantity higher than 1 because
quantities were applied after rounding, therefore multiplying
rounding inaccuracies which is not acceptable.
Currently the amounts output in line items does not reflect the more
accurate values. There needs to be an API change to display single
and total amounts for items in orders.
- Test plan
Adjusted a test to take the now accurate amounts.
- Description for the changelog
Fix increase of rounding inaccuracies through item quantity