Fix nut-scanner device naming in sanity-check reports
#2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v_num Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
the
USB-duplicate-devices
|
Had a CI agent reboot... Restarted build. |
… NOT always a "nut-serialX"!) Signed-off-by: Jim Klimov <[email protected]>
…erating WHOLE lists, not just parsing one "device" Signed-off-by: Jim Klimov <[email protected]>
…ev_num to size_t Signed-off-by: Jim Klimov <[email protected]>
jimklimov
force-pushed
the
nutscan-naming
branch
from
ede869c to
31ebf5e
Compare
|
✅ Build nut 2.8.1.1443-master completed (commit 5e9764232e by @jimklimov) |
…can_display_sanity_check_serial() Actually rewind it back to the number which the first entry for this device type had in the "continuous numbering" we track for this scan report. Signed-off-by: Jim Klimov <[email protected]>
jimklimov
force-pushed
the
nutscan-naming
branch
from
31ebf5e to
3628b0d
Compare
|
✅ Build nut 2.8.1.1445-master completed (commit 3386175b8b by @jimklimov) |
|
Looks good - don't have multiple devices to test with right now, but will follow up if a problem should appear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid this sort of mismatch:
[nutdev-usb1]vs....some devices: nutdev-serial1)It should rather be like this:
Fallout of #2243 / #2247.
Note: some testing with multiple devices would be welcome. I am not convinced if the sanity checker had a bug about starting
nutdev_numfrom thelast_nutdev_num(and moving the number upwards... to where the list has no entries to number?) - it could have reported bogus device numbers in fact. But that's a gut feeling, hopefully fixed by this PR if the bug was there...CC @desertwitch :)