Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eaton 9SX/9PX Fix for battery.voltage #2698

Merged

Conversation

masterwishx
Copy link
Contributor

@masterwishx masterwishx commented Nov 28, 2024

Eaton 9SX/9PX Fix for battery.voltage and battery.voltage.nominal by adding 9SX/9PX model to mge_model_names []
Fix #2685

Signed-off-by: DaRK AnGeL <[email protected]>
@jimklimov jimklimov added enhancement Eaton USB Incorrect or missing readings On some devices driver-reported values are systemically off (e.g. x10, x0.1, const+Value, etc.) labels Nov 28, 2024
@jimklimov jimklimov added this to the 2.8.3 milestone Nov 28, 2024
@jimklimov jimklimov added the need testing Code looks reasonable, but the feature would better be tested against hardware or OSes label Nov 28, 2024
@AppVeyorBot
Copy link

@masterwishx
Copy link
Contributor Author

@jimklimov i think Eaton 9PX should be added also !?

@jimklimov
Copy link
Member

Maybe, if you are sure about its ID.

Signed-off-by: DaRK AnGeL <[email protected]>
@masterwishx
Copy link
Contributor Author

Maybe, if you are sure about its ID.

i got them from manual

Signed-off-by: DaRK AnGeL <[email protected]>
@masterwishx
Copy link
Contributor Author

masterwishx commented Nov 28, 2024

base 9PX models included , also available with same ID +:

-L = Lithium
BS = with BS input cord
TN = Network card included

can be added later in case we need ?

@masterwishx masterwishx changed the title Eaton 9SX Fix for battery.voltage Eaton 9SX/9PX Fix for battery.voltage Nov 28, 2024
Signed-off-by: DaRK AnGeL <[email protected]>
@jimklimov
Copy link
Member

CI faults on openbsd are irrelevant, had a build agent problem

@jimklimov jimklimov merged commit 3911e13 into networkupstools:master Nov 30, 2024
27 of 35 checks passed
@masterwishx masterwishx deleted the eaton-9sx-battery.voltage-fix branch November 30, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eaton enhancement Incorrect or missing readings On some devices driver-reported values are systemically off (e.g. x10, x0.1, const+Value, etc.) need testing Code looks reasonable, but the feature would better be tested against hardware or OSes USB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eaton 9SX Model usbhid-ups: battery.voltage value is missing
3 participants