-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SNMP support for Baytech RPC3-NC PDUs #2779
Conversation
Some models of Baytech RPC3-NC PDUs do not have a value at ".1.3.6.1.4.1.4779.1.3.5.2.1.24.1", causing the sysOID match to fail. Added a 2nd MIB that looks at ".1.3.6.1.4.1.4779.1.3.5.5.1.3.2.1" instead. This patch would fall under the "various RPC" entry in the hardware compatibility list, thus the list does not need updating. Signed-off-by: Noah Jacobson <[email protected]>
Signed-off-by: Noah Jacobson <[email protected]>
Cheers, and thanks for the contribution. If the mappings are all the same, you can get away defining an additional As for the distcheck, we also have a |
Hi there. I initially tried to implement a 2nd
Thank you! |
Well, I guess passing distcheck on your side is not strictly required - it would try and might fail on CI side, after a few hundred CPU hours across different platforms, which is the authoritative answer for the ultimate merge anyway. Passing (or especially failing) it locally in one use-case just speeds up that part. |
…s#2779] Signed-off-by: Jim Klimov <[email protected]>
Some models of Baytech RPC3-NC PDUs do not have a value at ".1.3.6.1.4.1.4779.1.3.5.2.1.24.1", causing the sysOID match to fail. Added a 2nd MIB that looks at ".1.3.6.1.4.1.4779.1.3.5.5.1.3.2.1" instead.
This patch would fall under the "various RPC" entry in the hardware compatibility list, thus the list does not need updating.
I was unable to run
make distcheck
, it appears to require quite a few dependencies that are not on my system.