Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX remove regressor multi_label tag #339

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FIX remove regressor multi_label tag #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d9b6ea
FIX remove regressor multi_label tag
PSSF23 Dec 12, 2024
58841ce
FIX add comment for future regression support
PSSF23 Dec 17, 2024
9b2e258
FIX update macOS test environment
PSSF23 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
matrix:
os: # see scipy wheels.yml GH actions
- [ubuntu-22.04, manylinux, x86_64]
- [macos-12, macosx, x86_64]
- [macos-latest, macosx, x86_64]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my education, why do we need this change?

# - [macos-12, macosx_*, arm64]
- [windows-2019, win, AMD64]

Expand Down
2 changes: 1 addition & 1 deletion treeple/tree/_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2441,7 +2441,7 @@ def __sklearn_tags__(self):
# XXX: nans should be supportable in SPORF by just using RF-like splits on missing values
# However, for MORF it is not supported
tags = super().__sklearn_tags__()
tags.regressor_tags.multi_label = True
# tags.regressor_tags.multi_label = True TODO: add regression support
tags.input_tags.allow_nan = False
return tags

Expand Down
Loading