Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-Click Postage: Don't fallback to main blog on failure #2138

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

marcustyphoon
Copy link

@marcustyphoon marcustyphoon commented Oct 19, 2023

This removes a mystifying behavior in which One-Click Postage would, on any failure to post, do its single retry attempt with the target blog changed to the user's main.

This is a common complaint when the post author has the user's sideblog blocked. Silently reblogging to the wrong location in this case makes zero sense.

I'm sure there was a reason for this originally (maybe accessing sideblogs was unreliable?) but I can imagine no case in which the post winding up in the wrong place was a good fallback. If you can't do what the user wants, just fail the action. Simple as that.

(I didn't check if this merge conflicts with #2137, but if it does I'll fix the conflict after either is merged. If it matters, of course—I'm not willing to go out of my way to solicit further discussion.)

@marcustyphoon
Copy link
Author

Tested by making a post on one of my testing accounts, blocking one of my sideblogs, and attempting to reblog the post onto that sideblog:

Screenshot 2023-10-18 at 7 39 55 PM

Copy link
Member

@AprilSylph AprilSylph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and I trust your testing, especially for such a straightforward change.

Up to you whether to wait for @nightpool's review before merging.

@AprilSylph AprilSylph merged commit 458c2cf into new-xkit:master Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants