-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Credential Engine launch #2415
Open
ChelseaKR
wants to merge
1,023
commits into
main
Choose a base branch
from
credential-engine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
196d379
to
c609043
Compare
da6bc08
to
efa049a
Compare
…t to trainings/all
NJWE-1847- New endpoint to retrieve all trainings from CE
…ntains matches for learning opportunity profile ceterms:name an ceterms:description
fix deliverytype
Scott/training page skeleton
…ssing data - Simplified access to nested fields using optional chaining (?.). - Added null coalescing (??) to provide default values for missing data. - Ensured better handling of edge cases, such as missing or incomplete contact information. - Improved code clarity and reduced redundancy.
…ory` - Added `normalizeQueryParams` to standardize query parameters for consistent cache keys. - Updated caching logic to dynamically use normalized parameters and reduce cache misses. - Enhanced logging to distinguish cache hits and misses for better observability. - Renamed functions for clarity: `filterCerts` -> `filterRecords`, `paginateCerts` -> `paginateRecords`. - Preserved existing functionality for filtering, sorting, and pagination. This refactor improves caching efficiency, reduces redundant API calls, and enhances code readability.
- Renamed `transformCertificateToTraining` to `transformLearningOpportunityCTDLToTrainingResult` for clarity. - Updated variable naming for consistency (`allCerts` -> `learningOpportunities`).
- Added `tokenize` and `levenshteinDistance` functions to support text processing. - Introduced `rankResults` to rank search results based on query relevance. - Integrated ranking into `searchTrainingsFactory` to improve search accuracy. - Included `description` in the `TrainingResult` transformation for better matching. This update enhances search result quality by prioritizing relevant results.
- Added provider name (`ceterms:ownedBy`) to ranking to improve search results. - Introduced `STOP_WORDS` set to prevent stripping essential provider words. - Increased proper noun weighting in `rankResults` for better relevance. - Adjusted tokenization to retain hyphens, numbers, and spaces. - Boosted exact name matches significantly to prioritize precise results. - Added fuzzy matching logic for minor spelling variations. - Improved phrase matching by including description and provider name. These updates ensure better recall and precision when searching for training opportunities.
- Boost exact provider name matches (+15,000) to prioritize direct matches - Boost exact training program name matches (+2,000) for more relevant results - Add location-based boosting (+1,500 per match) to prioritize local results - Increase weight for multi-word phrase matches (+500) to improve precision - Penalize unrelated results (-2,000) if neither provider nor training name matches These changes ensure that searches like "Workforce Advantage - Elizabeth nursing" prioritize relevant programs from the correct provider and location.
… Contact Details"
…cified text should be hidden if provider does not give that info"
- Refactored `rankResults` function: - Introduced `COMMON_WORDS` set to filter out generic terms. - Improved token-based matching with weighted scores. - Enhanced fuzzy matching efficiency. - Set a minimum score threshold for relevance filtering. - Improved query filtering: - Standardized tokenization for training names, descriptions, and providers. - Boosted ranking for strong matches and removed low-relevance results. - Added additional logging for debugging and performance insights. This refactor enhances search accuracy, reduces noise, and improves result ranking consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.