Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: health inst #171

Draft
wants to merge 1 commit into
base: dbudziwojski/update-scaffolding
Choose a base branch
from

Conversation

danielstokes
Copy link
Contributor

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@danielstokes danielstokes changed the base branch from main to dbudziwojski/update-scaffolding December 31, 2024 21:31
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 49.86351% with 551 lines in your changes missing coverage. Please review.

Please upload report for BASE (dbudziwojski/update-scaffolding@a4436e1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/internal/instrumentation/health.go 69.48% 107 Missing and 23 partials ⚠️
src/internal/instrumentation/util/ticker/ticker.go 0.00% 67 Missing ⚠️
src/internal/controller/pod_controller.go 0.00% 62 Missing ⚠️
src/internal/controller/namespace_controller.go 0.00% 56 Missing ⚠️
src/api/v1alpha2/zz_generated.deepcopy.go 0.00% 50 Missing ⚠️
.../internal/controller/instrumentation_controller.go 0.00% 50 Missing ⚠️
src/api/v1alpha2/instrumentation_webhook.go 0.00% 39 Missing ⚠️
...nternal/instrumentation/util/worker/manyworkers.go 80.72% 15 Missing and 1 partial ⚠️
src/internal/instrumentation/health_check.go 53.12% 10 Missing and 5 partials ⚠️
src/internal/apm/health.go 89.38% 8 Missing and 4 partials ⚠️
... and 12 more
Additional details and impacted files
@@                        Coverage Diff                         @@
##             dbudziwojski/update-scaffolding     #171   +/-   ##
==================================================================
  Coverage                                   ?   55.17%           
==================================================================
  Files                                      ?       31           
  Lines                                      ?     2617           
  Branches                                   ?        0           
==================================================================
  Hits                                       ?     1444           
  Misses                                     ?     1060           
  Partials                                   ?      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant