-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow Fields Specification and Capture Nearest Fields #1267
Open
metal-messiah
wants to merge
6
commits into
main
Choose a base branch
from
user-action-custom-props
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal-messiah
changed the title
feat: customize user actions attributes for internap product analytics
feat: customize user actions attributes for internal product analytics
Dec 2, 2024
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
+ Coverage 88.67% 88.72% +0.04%
==========================================
Files 170 170
Lines 7314 7327 +13
Branches 1478 1480 +2
==========================================
+ Hits 6486 6501 +15
- Misses 714 715 +1
+ Partials 114 111 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
metal-messiah
changed the title
feat: customize user actions attributes for internal product analytics
feat: Allow Fields Specification and Capture Nearest Fields
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration to specify what fields to capture from target elements. This change extends that behavior to also search up the parent tree for the "nearest" matching field when not present on the target.
Overview
This was spawned from feedback and POC tied to internal NR1 use cases and product analytics. Exposing to customer base to benefit all.
Related Issue(s)
NR-359755
Testing
Test has been added