Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix iOS webview test with LT #1333

Merged
merged 1 commit into from
Jan 16, 2025
Merged

chore: Fix iOS webview test with LT #1333

merged 1 commit into from
Jan 16, 2025

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Jan 16, 2025

Please add a one-paragraph summary here, suitable for a release notes description. This will help with documentation.

Overview

Hats to @jporter

Related Issue(s)

Testing

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.75 kB / 10.79 kB (gzip) 29.75 kB / 10.79 kB (gzip) 0% / 0% (gzip)
lite async-chunk 52.31 kB / 16.97 kB (gzip) 52.31 kB / 16.97 kB (gzip) 0% / 0% (gzip)
pro loader 51.4 kB / 17.74 kB (gzip) 51.4 kB / 17.74 kB (gzip) 0% / 0% (gzip)
pro async-chunk 99.14 kB / 30.24 kB (gzip) 99.14 kB / 30.24 kB (gzip) 0% / 0% (gzip)
spa loader 59.02 kB / 20.07 kB (gzip) 59.02 kB / 20.07 kB (gzip) 0% / 0% (gzip)
spa async-chunk 113.85 kB / 34.58 kB (gzip) 113.85 kB / 34.58 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (ce7402e) to head (d80a6d8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         170      170           
  Lines        7314     7314           
  Branches     1478     1478           
=======================================
  Hits         6485     6485           
  Misses        715      715           
  Partials      114      114           
Flag Coverage Δ
unit-tests 79.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24 cwli24 merged commit 86943eb into main Jan 16, 2025
16 checks passed
@cwli24 cwli24 deleted the fix-ios-webview branch January 16, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants