Fix crash in memory metric calculations (#257)

newrelic · Jun 29, 2021 · 697a326 · 697a326
1 parent d40ff60
commit 697a326
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/newrelic/samplers/memory_usage.py b/newrelic/samplers/memory_usage.py
@@ -27,14 +27,14 @@
 
 @data_source_generator(name="Memory Usage")
 def memory_usage_data_source():
-    yield ("Memory/Physical", physical_memory_used())
-    yield ("Memory/Physical/%d" % (PID), physical_memory_used())
-
-    yield (
-        "Memory/Physical/Utilization",
-        physical_memory_used() / total_physical_memory(),
-    )
-    yield (
-        "Memory/Physical/Utilization/%d" % (PID),
-        physical_memory_used() / total_physical_memory(),
+    memory = physical_memory_used()
+    total_memory = total_physical_memory()
+    memory_utilization = (
+        (memory / total_memory) if None not in (memory, total_memory) else None
     )
+
+    yield ("Memory/Physical", memory)
+    yield ("Memory/Physical/%d" % (PID), memory)
+
+    yield ("Memory/Physical/Utilization", memory_utilization)
+    yield ("Memory/Physical/Utilization/%d" % (PID), memory_utilization)