Remove version lock on haml in Rails multiverse #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimpleCov Report
|
Tilt no longer ships ERubis, but haml 5.1.2 requires it. The previous haml verison was locked to the newest version at the time it was updated. It also reduces the number of old Rails versions running on haml-rails 1.0. Co-authored-by: hramadan <[email protected]>
kaylareopelle
force-pushed
the
haml-update
branch
from
f7d97c4 to
24afb4e
Compare
kaylareopelle
requested review from
hannahramadan and
tannalynn
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI with the other Rails versions passing also: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12519740439
(timeouts though for some of the
restsuite)