Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to exclude previews from backup upon instance backup #5892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devnoname120
Copy link
Contributor

Follow up of: #5550

@szaimen I haven't tested the changes yet as I don't have the right setup… Is there any chance you could test them? Thanks!

@devnoname120 devnoname120 force-pushed the exclude-previews-from-backup branch from 40bc5d4 to eeef048 Compare January 17, 2025 00:12
@devnoname120
Copy link
Contributor Author

Edit: I added Signed-off-by: Paul <[email protected]> to the end of the commit message and then force-pushed to make DCO pass.

@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Jan 17, 2025
@devnoname120 devnoname120 force-pushed the exclude-previews-from-backup branch 2 times, most recently from 5e354ea to 0e471d4 Compare January 20, 2025 13:16
@devnoname120 devnoname120 force-pushed the exclude-previews-from-backup branch from 0e471d4 to ce5ac63 Compare January 20, 2025 19:19
@devnoname120
Copy link
Contributor Author

@szaimen Is there a way to test the changes on my side on my production instance? I tried looking into building the whole AIO thing but there doesn't seem to be an easy way to do that. The actual docker build pipeline seem to be defined in the nextcloud-releases repo: https://github.com/nextcloud-releases/all-in-one/blob/main/.github/workflows/build_images.yml

I vaguely tried to pull the CI workflow change it to push to ghcr.io (to my own fork) instead of docker.io but the references to docker.io look farther reaching than just in the CI pipelines so I quickly gave up…

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devnoname120 thanks a lot for the contribution and sorry for my late reply!

I unfortunately have some problems with this as in my opinion, the backup should always represent a full backup with intact database and file system and basically including all data needed to restore the same state without exception. This also includes the previews as their path is also written into the database. Allowing to exclude the previews means that we always need to scan the database upon restore which is hacky imho.

Also, maybe we could find a better way that allows to exclude previews and more without having to add an option to the interface for each thing? This could probably be implemented like this: #4751. Would you be able to work on this?

Please let me know what you think about my thoughts!

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants