Fix wrong failure-msg when clearing photo-cache. #1375
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@come-nc What do you think? I would prefere having the Icache->clear() funktion fixed. But this is far out of our code space. So I'm fine. |
umgfoin
force-pushed
the
PR_fix_wrong_photocache_failure-msg
branch
from
3d0359b to
61dec6f
Compare
bool GeophotoService::clearCache returns false, if any of the cleared caches was already empty. Accordingly a failure-msg is shown in the maps-GUI. This change makes the function always return true unless an exception occurred - then false is returned. Signed-off-by: umgfoin <[email protected]>
umgfoin
force-pushed
the
PR_fix_wrong_photocache_failure-msg
branch
from
61dec6f to
b473113
Compare
Signed-off-by: umgfoin <[email protected]>
umgfoin
force-pushed
the
PR_fix_wrong_photocache_failure-msg
branch
from
a40a929 to
2d502d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bool GeophotoService::clearCachereturnsfalse, if any of the cleared caches was already empty.Accordingly, a failure-msg is shown in the maps-GUI.
This change makes the function always return
trueunless an exception occurred - thenfalseis returned.