Download feed logos via guzzle to have better error handling #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
changed the title
Signed-off-by: Benjamin Brahmer <[email protected]>
|
Runs fine on my dev server, will deploy this on my prod server. |
|
If someone wants to test, build and officially signed by me (no new version number) |
Signed-off-by: Benjamin Brahmer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1533 +/- ##
============================================
- Coverage 92.00% 91.37% -0.64%
- Complexity 766 768 +2
============================================
Files 65 65
Lines 2803 2816 +13
============================================
- Hits 2579 2573 -6
- Misses 224 243 +19
Continue to review full report at Codecov.
|
SMillerDev
reviewed
Oct 17, 2021
Signed-off-by: Benjamin Brahmer <[email protected]> Co-authored-by: Sean Molenaar <[email protected]>
Signed-off-by: Benjamin Brahmer <[email protected]> Co-authored-by: Sean Molenaar <[email protected]>
|
New version including all the changes. |
SMillerDev
approved these changes
Oct 17, 2021
|
I plan to extend this solution to also support proxies and make use of the general config, but incremental working changes are better than the big bang that doesn't work. |
Grotax
added a commit
that referenced
this pull request
Oct 18, 2021
Changed - Add changelog and DCO notice to CONTRIBUTING.md (#1521) - Download feed logos via guzzle to have better error handling (#1533) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Oct 20, 2021
Changed - Add changelog and DCO notice to CONTRIBUTING.md (#1521) - Download feed logos via guzzle to have better error handling (#1533) Signed-off-by: Benjamin Brahmer <[email protected]>
Neo11
pushed a commit
to Neo11/news
that referenced
this pull request
May 28, 2022
Changed - Add changelog and DCO notice to CONTRIBUTING.md (nextcloud#1521) - Download feed logos via guzzle to have better error handling (nextcloud#1533) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to replace php's simple copy function by guzzle.