-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lift min PHP version and NC #2687
Conversation
16cc083
to
a7a2c23
Compare
f6e268d
to
6677da5
Compare
6677da5
to
00ac4ec
Compare
rebased |
00ac4ec
to
9d6fe64
Compare
Hey, I tried to look into the failing tests but got stuck at some point. One of my findings was that in the search providers we have
Which is no longer needed nc29+ versions will all have the getFilter method so also in the test the getfilter method is called and not getTerm don't know how to mock the result though. Also looked again into the issue with the deprecated method withConsecutive can't find any proper replacement. |
Yeah, I fixed the search provider in one place. Let me see if I can do it in others too. |
9d6fe64
to
077e750
Compare
e8f47ab
to
c657e46
Compare
Okay, now all deprecations should be fixed. |
e8e1955
to
392144d
Compare
392144d
to
e422369
Compare
Signed-off-by: Sean Molenaar <[email protected]>
e422369
to
f05119b
Compare
Nice, but it feel strange to require PHP 8.2 as min version since nextcloud 29 allow PHP 8.1 cf https://docs.nextcloud.com/server/29/admin_manual/installation/system_requirements.html |
It's the minimum recommended version, and I don't really have time to volunteer for support of old PHP versions. |
I fully understand, i was just pointing that it's strange than an app doesn't follow the same requirement of the core :) |
There's really no connection between core and this app, so it's not that odd we're setting our own standards |
Summary
Update some PHP usage and update NC usage
Checklist